From 73ff0a9d454c3e30ccdabc55537e671933b61cb3 Mon Sep 17 00:00:00 2001
From: Victor Andersson <victor.andersson2@elev.ga.ntig.se>
Date: Tue, 11 Nov 2025 20:48:12 +0100
Subject: [PATCH] fix: use precomputed permission flags in template

---
 claims/templates/claims/user_management.html | 10 +++++-----
 claims/views.py                              |  8 ++++++++
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/claims/templates/claims/user_management.html b/claims/templates/claims/user_management.html
index 5202a55..c26e6ff 100644
--- a/claims/templates/claims/user_management.html
+++ b/claims/templates/claims/user_management.html
@@ -111,11 +111,11 @@
                         <div class="rounded-2xl bg-slate-50 p-4">
                             <p class="text-sm font-semibold text-gray-700">{% trans "Behörigheter" %}</p>
                             <div class="mt-3 flex flex-wrap gap-2 text-xs">
-                                <span class="rounded-full px-3 py-1 {% if user.is_staff %}bg-emerald-100 text-emerald-800{% else %}bg-slate-200 text-slate-600{% endif %}">{% trans "Admin/staff" %}</span>
-                                <span class="rounded-full px-3 py-1 {% if user.has_perm('claims.view_claim') %}bg-blue-100 text-blue-800{% else %}bg-slate-200 text-slate-600{% endif %}">{% trans "Får se utlägg" %}</span>
-                                <span class="rounded-full px-3 py-1 {% if user.has_perm('claims.change_claim') %}bg-indigo-100 text-indigo-800{% else %}bg-slate-200 text-slate-600{% endif %}">{% trans "Får besluta utlägg" %}</span>
-                                <span class="rounded-full px-3 py-1 {% if user.has_perm('claims.edit_claim_details') %}bg-purple-100 text-purple-800{% else %}bg-slate-200 text-slate-600{% endif %}">{% trans "Får redigera utlägg" %}</span>
-                                <span class="rounded-full px-3 py-1 {% if user.has_perm('claims.mark_claim_paid') %}bg-amber-100 text-amber-800{% else %}bg-slate-200 text-slate-600{% endif %}">{% trans "Får markera betalningar" %}</span>
+                                <span class="rounded-full px-3 py-1 {% if row.permission_flags.is_staff %}bg-emerald-100 text-emerald-800{% else %}bg-slate-200 text-slate-600{% endif %}">{% trans "Admin/staff" %}</span>
+                                <span class="rounded-full px-3 py-1 {% if row.permission_flags.view %}bg-blue-100 text-blue-800{% else %}bg-slate-200 text-slate-600{% endif %}">{% trans "Får se utlägg" %}</span>
+                                <span class="rounded-full px-3 py-1 {% if row.permission_flags.change %}bg-indigo-100 text-indigo-800{% else %}bg-slate-200 text-slate-600{% endif %}">{% trans "Får besluta utlägg" %}</span>
+                                <span class="rounded-full px-3 py-1 {% if row.permission_flags.edit %}bg-purple-100 text-purple-800{% else %}bg-slate-200 text-slate-600{% endif %}">{% trans "Får redigera utlägg" %}</span>
+                                <span class="rounded-full px-3 py-1 {% if row.permission_flags.pay %}bg-amber-100 text-amber-800{% else %}bg-slate-200 text-slate-600{% endif %}">{% trans "Får markera betalningar" %}</span>
                             </div>
                             <button type="button"
                                     data-open-permission-edit="{{ user.id }}"
diff --git a/claims/views.py b/claims/views.py
index 3b1dbdb..b739e55 100644
--- a/claims/views.py
+++ b/claims/views.py
@@ -377,6 +377,13 @@ class UserManagementView(LoginRequiredMixin, PermissionRequiredMixin, TemplateVi
         users = User.objects.order_by("username")
         rows = []
         for user in users:
+            perms = {
+                "is_staff": user.is_staff,
+                "view": user.has_perm("claims.view_claim"),
+                "change": user.has_perm("claims.change_claim"),
+                "edit": user.has_perm("claims.edit_claim_details"),
+                "pay": user.has_perm("claims.mark_claim_paid"),
+            }
             rows.append(
                 {
                     "user": user,
@@ -390,6 +397,7 @@ class UserManagementView(LoginRequiredMixin, PermissionRequiredMixin, TemplateVi
                             "grant_pay": user.has_perm("claims.mark_claim_paid"),
                         }
                     ),
+                    "permission_flags": perms,
                     "delete_form": None
                     if user == self.request.user or user.is_superuser
                     else DeleteUserForm(initial={"user_id": user.id}),